Skip to content

Conversation

PranavSenthilnathan
Copy link
Member

.NETFramework requires more refactoring so I'm planning on doing it in a separate PR

Contributes to #116998

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@PranavSenthilnathan PranavSenthilnathan marked this pull request as ready for review July 31, 2025 17:03
@Copilot Copilot AI review requested due to automatic review settings July 31, 2025 17:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements EC-DSA (Elliptic Curve Digital Signature Algorithm) support for Composite ML-DSA algorithms on .NET 8+. The implementation adds EC-DSA as a second component alongside ML-DSA for quantum-resistant cryptographic schemes.

  • Adds a new CompositeMLDsaManaged.ECDsa.cs file implementing the EC-DSA component for Composite ML-DSA
  • Updates algorithm metadata to include specific curve and hash algorithm parameters for EC-DSA variants
  • Enhances test coverage with additional validation scenarios and cross-algorithm tests

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
System.Security.Cryptography.csproj Adds the new ECDsa component file to the build
Microsoft.Bcl.Cryptography.csproj Adds the new ECDsa component file to the BCL package
CompositeMLDsaTestsBase.cs Updates test methods to properly handle variable signature sizes and adds missing test scenarios
CompositeMLDsaTestHelpers.cs Adds SEC curve distinction and improves algorithm parameter handling
CompositeMLDsaFactoryTests.cs Adds comprehensive tests for ECDsa key import validation and cross-algorithm error scenarios
CompositeMLDsaManaged.cs Updates algorithm metadata with specific ECDsa parameters and removes placeholder implementation
CompositeMLDsaManaged.RSA.cs Adds key size validation for RSA component imports
CompositeMLDsaManaged.ECDsa.cs New file implementing full ECDsa component with key generation, import/export, and signing/verification

@PranavSenthilnathan PranavSenthilnathan added this to the 10.0.0 milestone Aug 4, 2025
@PranavSenthilnathan PranavSenthilnathan merged commit d50bb8e into dotnet:main Aug 4, 2025
84 of 87 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants