Skip to content

Remove some unnecessary #if TARGET_64BIT #118361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2025
Merged

Remove some unnecessary #if TARGET_64BIT #118361

merged 3 commits into from
Aug 30, 2025

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 4, 2025

No description provided.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 4, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 4, 2025
This was referenced Aug 5, 2025
Closed
Open
Open
Open
jkotas
jkotas reviewed Aug 5, 2025
View reviewed changes
@jkotas
Copy link
Member

jkotas commented Aug 11, 2025

Failing tests

                 08-04 13:31:55.246 29042 29549 I DOTNET  : 1) 	[FAIL] System.Tests.UIntPtrTests_GenericMath.CreateSaturatingFromSingleTest   Test name: System.Tests.UIntPtrTests_GenericMath.CreateSaturatingFromSingleTest
                 08-04 13:31:55.247 29042 29549 I DOTNET  :    Assembly:  [System.Runtime.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]
                 08-04 13:31:55.247 29042 29549 I DOTNET  :    Exception messages: Assert.Equal() Failure: Values differ

@jkotas jkotas added needs-author-action An issue or pull request that requires more info or actions from the author. area-System.Numerics and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 11, 2025
@dotnet-policy-service dotnet-policy-service bot added no-recent-activity and removed needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity labels Aug 25, 2025
@xtqqczze
Copy link
Contributor Author

Failing tests

                 08-04 13:31:55.246 29042 29549 I DOTNET  : 1) 	[FAIL] System.Tests.UIntPtrTests_GenericMath.CreateSaturatingFromSingleTest   Test name: System.Tests.UIntPtrTests_GenericMath.CreateSaturatingFromSingleTest
                 08-04 13:31:55.247 29042 29549 I DOTNET  :    Assembly:  [System.Runtime.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]
                 08-04 13:31:55.247 29042 29549 I DOTNET  :    Exception messages: Assert.Equal() Failure: Values differ

addressed b3b4174

This was referenced Aug 29, 2025
Open
Open
Open
Closed
@jkotas jkotas merged commit 1c3221b into dotnet:main Aug 30, 2025
144 checks passed
@xtqqczze xtqqczze deleted the rm-TARGET_64BIT branch August 30, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannergooding tannergooding tannergooding left review comments

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @jkotas @tannergooding