[clr-interp] Fix issues found in the startup path with the interpreter #118497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Aug 7, 2025
davidwrighton
commented
- Fix virtual function resolution might not handle dispatch to a shared generic method if the exact type of the method is visible at compile time
- Fix ldelema for an array of reference types doesn't handle shared generics properly
- Fix issue where the readonly prefix for ldelema is ignored
- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use
Co-authored-by: Copilot <[email protected]>
…dwrighton/runtime into MakeDelegateInvokeIntrinsic
Co-authored-by: Jan Kotas <[email protected]>
This change fixes the following issues: * Reverse pinvoke to method marked by UnmanagedCallersOnly attribute. The InterpExecMethod is entered in GC preemptive mode in that case, but it is expected to run in GC cooperative mode. * Pinvoke to method marked by SuppressGCTransition attribute . The pinvoke is entered in GC preemtive mode, but it needs to be called in GC cooperative mode. * Calling a delegate or a similar case when IL stub is used. The interpreter code is set only on the IL stub MethodDesc, but it needs to be set on both the IL stub and the original MethodDesc.
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
No longer needed after the previous commit
…nto MakeDelegateInvokeIntrinsic
- Fix virtual function resolution might dispatch to the wrong location - Fix ldelema for an array of reference types doesn't handle shared generics properly - Fix the readonly prefix for ldelema is ignored.
…dwrighton/runtime into MakeDelegateInvokeIntrinsic
github-actions
bot
added
the
needs-area-label
kg
reviewed
Aug 7, 2025
mangod9
added
area-VM-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @mangod9 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.