Eliminate NextCallReturnAddress call followed by CEE_POP #118500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sequence should be handled as no-op
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the interpreter by eliminating redundant calls to System.StubHelpers.NextCallReturnAddress when immediately followed by a CEE_POP instruction, treating this sequence as a no-op operation.
Key Changes:
- Add recognition for
System.StubHelpers.NextCallReturnAddressas a named intrinsic - Implement special handling to skip both the call and subsequent
CEE_POPinstruction when detected together
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/interpreter/intrinsics.cpp | Adds intrinsic recognition for System.StubHelpers.NextCallReturnAddress method |
| src/coreclr/interpreter/compiler.cpp | Implements no-op optimization by detecting and skipping the call+pop sequence |
davidwrighton
approved these changes
Aug 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sequence should be handled as no-op