-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Put different arches in different yml for NativeAOT Android pipelines #118622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorganizes Android platform builds by separating different architectures into different pipeline YAML files. The change moves android_x64
exclusively to the Android emulator pipeline and android_arm64
exclusively to the main Android pipeline.
Key Changes:
- Removes
android_arm64
from the Android emulator pipeline - Removes
android_x64
from the main Android pipeline - Creates architecture-specific separation between emulator and device builds
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
eng/pipelines/extra-platforms/runtime-extra-platforms-androidemulator.yml | Removes android_arm64 platform from emulator builds |
eng/pipelines/extra-platforms/runtime-extra-platforms-android.yml | Removes android_x64 platform from main Android builds |
eng/pipelines/extra-platforms/runtime-extra-platforms-androidemulator.yml
Show resolved
Hide resolved
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
/ba-g All failures unrelated |
Splitting to only arm64 for regular and only x64 for emulator makes sense. But in general, should we have the emulator jobs include emulator in the name? Not allowing the same architecture in regular and emulator seems like a weird limitation just due to how those jobs are named. And emulator seems like reasonable information to have in the title. |
Should fix #118621
runtime-extra-platforms pulls in both runtime-android and runtime-androidemulator. NativeAOT has runs for the same arches in both of those, creating duplicates. This follows the CoreCLR pattern and runs one arch in runtime-android and one in tuneim-androidemulator.