Skip to content

Conversation

jtschuster
Copy link
Member

@jtschuster jtschuster commented Aug 12, 2025

Should fix #118621

runtime-extra-platforms pulls in both runtime-android and runtime-androidemulator. NativeAOT has runs for the same arches in both of those, creating duplicates. This follows the CoreCLR pattern and runs one arch in runtime-android and one in tuneim-androidemulator.

@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 03:31
@jtschuster
Copy link
Member Author

/azp run runtime-extra-platforms

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 12, 2025
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes Android platform builds by separating different architectures into different pipeline YAML files. The change moves android_x64 exclusively to the Android emulator pipeline and android_arm64 exclusively to the main Android pipeline.

Key Changes:

  • Removes android_arm64 from the Android emulator pipeline
  • Removes android_x64 from the main Android pipeline
  • Creates architecture-specific separation between emulator and device builds

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/pipelines/extra-platforms/runtime-extra-platforms-androidemulator.yml Removes android_arm64 platform from emulator builds
eng/pipelines/extra-platforms/runtime-extra-platforms-android.yml Removes android_x64 platform from main Android builds

@jtschuster
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtschuster jtschuster requested a review from agocke August 12, 2025 15:00
@jtschuster jtschuster removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 12, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@jtschuster jtschuster enabled auto-merge (squash) August 12, 2025 15:02
@jtschuster jtschuster requested a review from vcsjones August 12, 2025 15:03
@jtschuster
Copy link
Member Author

/ba-g All failures unrelated

@jtschuster jtschuster changed the title Put different arches in different yml Put different arches in different yml for NativeAOT Android pipelines Aug 12, 2025
@jtschuster jtschuster merged commit 4a3629d into dotnet:main Aug 12, 2025
195 of 209 checks passed
@elinor-fung
Copy link
Member

Splitting to only arm64 for regular and only x64 for emulator makes sense. But in general, should we have the emulator jobs include emulator in the name? Not allowing the same architecture in regular and emulator seems like a weird limitation just due to how those jobs are named. And emulator seems like reasonable information to have in the title.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

runtime-extra-platforms pipeline is broken
3 participants