Avoid some Unsafe.As

[xtqqczze]

No diffs expected.

[EgorBo]

@MihuBot

[EgorBo]

Apparently, it's not no diffs
Feel free to file an issue against JIT with a repro

[EgorBo]

I think it's mostly around shared generics, e.g.:

using System;
using System.Runtime.CompilerServices;
using Microsoft.CodeAnalysis;

public class C
{
    public static void Main(string[] args)
    {
        Test<string>(new string[] { "Hello", "World" });
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    public static void Test<T>(object o)
    {
        if (o.GetType() == typeof(T[]))
            DoWork(Unsafe.As<T[]>(o));
            //DoWork((T[])o);
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    static void DoWork<T>(T[] _) { }
}

[xtqqczze]

@MihuBot

[EgorBo]

It's fine to merge single-line changes like this, I see the current change indeed is zero diff (as expected judging by the C# code), if you can find more candidates - the better 🙂

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@MihuBot

[xtqqczze]

It's fine to merge single-line changes like this, I see the current change indeed is zero diff (as expected judging by the C# code), if you can find more candidates - the better 🙂

Looks like we have an improvement in System.Buffers.AhoCorasickBuilder:BuildTrie(byref):this

[AaronRobinsonMSFT]

@EgorBo Do we have an Unsafe issue that we can record these PRs? We did this for the HelperMethodFrame removal and it was very helpful to track the body of work from so many.

[EgorBo]

@EgorBo Do we have an Unsafe issue that we can record these PRs? We did this for the HelperMethodFrame removal and it was very helpful to track the body of work from so many.

I think "reduce-unsafe" label should be enough.
Overall the main issue is #94941

[EgorBo]

Thanks!