Refactor code so it doesn't hit mono aot limitation #118698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrzVlad
requested review from
Copilot and
BrennanConroy
and removed request for
Copilot
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
BrennanConroy
approved these changes
Aug 13, 2025
This was referenced Aug 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was hitting a mono aot gsharedvt limitation described in #118697. This is not trivial and too risky to fix in time for .NET 10. The alternative easy fix is to pass the return byref.
This regressed after #118408.
Fixes #118576