Rename RuntimeType.IsInterface to avoid issues with Reflection
#118749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a narrow change to address a user reported issue on System.Runtime and the common implementation detail, System.RuntimeType.
AaronRobinsonMSFT
requested review from
steveisok,
vitek-karas and
MichalStrehovsky
as code owners
AaronRobinsonMSFT
changed the title
RuntimeType.IsInterface to avoid Reflection issues
There was a problem hiding this comment.
Pull Request Overview
This PR renames the internal IsInterface property to IsActualInterface across CoreCLR, NativeAot, and Mono runtimes to avoid reflection issues. The change addresses a user-reported issue where the IsInterface property name conflicts with reflection behavior.
Key changes:
- Introduced
IsActualInterfaceinternal property in all runtime implementations - Updated all internal usages to use the new property name
- Fixed project file reference in NativeAot to use the correct source file
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/System.Private.CoreLib/src/System/RuntimeType.Mono.cs | Added IsActualInterface property that delegates to IsInterface |
| src/libraries/System.Private.CoreLib/src/System/Type.cs | Updated to use IsActualInterface instead of IsInterface for RuntimeType |
| src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs | Updated three usages to call IsActualInterface |
| src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs | Updated validation logic to use IsActualInterface |
| src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeType.NativeAot.cs | Renamed IsInterface property to IsActualInterface |
| src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj | Fixed file reference from RuntimeType.cs to RuntimeType.NativeAot.cs |
| src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs | Renamed IsInterface property to IsActualInterface and updated all usages |
| src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/DynamicInterfaceCastableHelpers.cs | Updated to use IsActualInterface |
| src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs | Updated two usages to call IsActualInterface |
| src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs | Updated two usages to call IsActualInterface |
AaronRobinsonMSFT
changed the title
RuntimeType.IsInterface to avoid Reflection issuesRuntimeType.IsInterface to avoid issues with Reflection
|
@jkotas This seems to be all known errors, so "green". |
jkotas
approved these changes
Aug 14, 2025
This was referenced Aug 14, 2025
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a narrow change to address a user
reported issue on
System.Typeand thecommon implementation detail type,
RuntimeType.There are other related issues that discuss the underlying
Reflection behavior, see #98533 and #28056.
Fixes #118677