-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add tracing to hostpolicy_init_t::init
#118973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds extensive tracing throughout the hostpolicy_init_t::init
function to help debug an intermittent crash occurring in CI on macOS x64. The tracing is intended to be temporary and will help narrow down the crash location between corehost_load
and corehost_main
calls.
- Adds detailed trace logging for configuration parameters, framework definitions, and host information
- Instruments the
make_palstr_arr
helper function to trace array contents - Provides visibility into all major initialization steps and data structures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit.
Co-authored-by: Aaron Robinson <[email protected]>
This reverts commit 28216ac.
We're hitting an intermittent crash in CI on macOS x64. Without a dump, we just have the trace messages to narrow down where it is happening - seems to be between the start of
hostpolicy_init_t::init
(called bycorehost_load
) and whencorehost_main
is called (right aftercorehost_load
). This adds a bunch of tracing tohostpolicy_init_t::init
(can be removed when we figure out what is going on and where).See #118904
cc @dotnet/appmodel @AaronRobinsonMSFT