Skip to content

Conversation

elinor-fung
Copy link
Member

We're hitting an intermittent crash in CI on macOS x64. Without a dump, we just have the trace messages to narrow down where it is happening - seems to be between the start of hostpolicy_init_t::init (called by corehost_load) and when corehost_main is called (right after corehost_load). This adds a bunch of tracing to hostpolicy_init_t::init (can be removed when we figure out what is going on and where).

See #118904

cc @dotnet/appmodel @AaronRobinsonMSFT

@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 21:18
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds extensive tracing throughout the hostpolicy_init_t::init function to help debug an intermittent crash occurring in CI on macOS x64. The tracing is intended to be temporary and will help narrow down the crash location between corehost_load and corehost_main calls.

  • Adds detailed trace logging for configuration parameters, framework definitions, and host information
  • Instruments the make_palstr_arr helper function to trace array contents
  • Provides visibility into all major initialization steps and data structures

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit.

@elinor-fung elinor-fung merged commit 28216ac into dotnet:main Aug 22, 2025
150 of 152 checks passed
@elinor-fung elinor-fung deleted the hostpolicy-init-trace branch August 22, 2025 17:55
elinor-fung added a commit that referenced this pull request Sep 10, 2025
elinor-fung added a commit that referenced this pull request Sep 11, 2025
This reverts commit 28216ac.

This extra logging was added for investigating #118904 because it was intermittent and we couldn't get dumps. We can remove it now.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants