Skip to content

Conversation

kg
Copy link
Member

@kg kg commented Aug 21, 2025

Fixes JIT\Directed\pinning\object-pin\object-pin

@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 22:52
@kg kg requested review from BrzVlad and janvorli as code owners August 21, 2025 22:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for pinned IL locals in the CoreCLR interpreter by adding a pinned flag to track local variables that have the 'pinned' modifier and ensuring they are properly marked in the GC info.

  • Adds a pinned bit field to the InterpVar structure to track pinned variables
  • Updates local variable creation to detect and store the pinned modifier from IL
  • Modifies GC info generation to mark pinned variables with the GC_SLOT_PINNED flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/coreclr/interpreter/compiler.h Adds pinned field to InterpVar struct and updates CreateNextLocalVar signature
src/coreclr/interpreter/compiler.cpp Implements pinned variable detection, storage, and GC info marking

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@kg kg merged commit a33a89c into dotnet:main Aug 22, 2025
97 of 99 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants