[interp] Implement STELEM_U1 and STELEM_U2 #119026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements two new interpreter opcodes STELEM_U1 and STELEM_U2 for storing unsigned 1-byte and 2-byte values into arrays. The implementation fixes failing JIT SIMD VectorConvert tests by providing the missing interpreter support for these unsigned element store operations.
Key Changes
- Added
INTOP_STELEM_U1case for storinguint8_tvalues fromint32_tstack values - Added
INTOP_STELEM_U2case for storinguint16_tvalues fromint32_tstack values - Both implementations follow the existing pattern using the
STELEMmacro
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
This was referenced Aug 23, 2025
BrzVlad
approved these changes
Aug 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIT\SIMD\VectorConvert_ro_Target_64Bit and its kin