Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 25, 2025

Backport of #119068 to release/10.0 (RC2)

/cc @tannergooding @jeffhandley

Customer Impact

  • Customer reported
  • Found internally

Developers using Vector comparison APIs would see incorrect behavior for some overloads; while those using SquareRoot would see reduced performance.

Regression

  • Yes
  • No

The regressions were introduced as part of the several refactorings that removed the independent simdashwintrinsic support and changed it to reuse the hwintrinsic paths.

The general issue is that the System.Numerics vector API surface differs slightly from the modern System.Runtime.Intrinsics API surface. Namely it exposes some "legacy" overloads of the comparison APIs that return Vector<int> for comparisons involving Vector<float> and which uses a different name for a few APIs. While most of these special edge cases were handled as part of removing the simdashwintrinsic support, a couple were missed.

Testing

An explicit test covering the customer reported regression was added. Manual validation of the related scenarios and codegen was done.

Risk

Low. This is simply adding the long-existing flags to the table relevant table entries to ensure they go down the right code paths. There isn't really any "net new" code here which could introduce risk.

@jeffhandley jeffhandley added Servicing-consider Issue for next servicing release review area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI linkable-framework Issues associated with delivering a linker friendly framework labels Aug 25, 2025
@jeffhandley jeffhandley requested a review from artl93 August 25, 2025 22:39
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@lewing
Copy link
Member

lewing commented Aug 26, 2025

@artl93 since release/10.0 is m2 I assume your approval means this is servicing approved now?

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 26, 2025
@jeffschwMSFT jeffschwMSFT merged commit 6c6dac8 into release/10.0 Aug 26, 2025
111 of 115 checks passed
@jkotas jkotas deleted the backport/pr-119068-to-release/10.0 branch August 28, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants