[mono][interp] Fix attempt to free tiering data when tiering is disabled #119294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrzVlad
requested review from
kotlarmilos,
steveisok and
vitek-karas
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression where the interpreter attempts to free tiering-related data even when tiering is disabled. The issue was introduced in a previous PR (#119176) and wasn't caught because tiering is enabled by default in testing environments.
Key Changes
- Adds an early return guard to prevent processing when tiering is disabled
- Prevents potential crashes or undefined behavior when tiering functionality is turned off
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
kotlarmilos
approved these changes
Sep 3, 2025
|
/ba-g wasm unrelated failures |
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Sep 11, 2025
BrzVlad
added a commit
to BrzVlad/runtime
that referenced
this pull request
Sep 12, 2025
…otnet#119176) * [mono][interp] Fix leaking of compilation data For dynamic methods, imethod_alloc0 allocates from the dynamic method's mempool which is freed when the method is collected. We were previously allocating only from the global memory manager. * [mono][interp] Stop leaking data items Previously we were registering imethod locations from these data items in order for them to be patched once a method is tiered up. Because of this registering, the data item had to always be around. We now free the data item for dynamic methods and also we deregister the patch locations when freeing such a method. * [mono][interp] Free headers allocated for inlined methods We add them to a list for later freeing. This uses the same pattern as jit. * [mono][interp] Skip interp free for methods not yet compiled Fix attempt to free tiering data when tiering is disabled (dotnet#119294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed after #119176. Tiering is enabled by default so this bug slipped through.