Add test for issue #114813 #119374
Open
Add test for issue #114813 #119374
+1,686
−1,584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a regression test for issue #114813, which appears to be related to DateTimeOffset serialization when using DataContractSerializer within an IXmlSerializable implementation. The test is designed to validate that DateTimeOffset values round-trip correctly in this specific scenario.
Key changes:
- Added a new test container class
DateTimeOffsetIXmlSerializableContainerthat implements IXmlSerializable - Added a test method
DCS_DateTimeOffsetInIXmlSerializableContainerto verify proper serialization/deserialization behavior
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SerializationTypes.cs | Added DateTimeOffsetIXmlSerializableContainer class that wraps DateTimeOffset serialization using DataContractSerializer within IXmlSerializable implementation |
| DataContractSerializer.cs | Added test method to verify DateTimeOffset round-trip serialization works correctly in the IXmlSerializable scenario |
src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for issue #114813
Will fail if merged before fix (PR #114969)