[interp] Disable tests in the interop suite so that it can complete executing #120074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
added
NO-MERGE
There was a problem hiding this comment.
Pull Request Overview
This PR adds test skipping logic for interpreter mode in the .NET runtime test suite. It introduces a new InterpreterActive runtime test mode and applies skip attributes to various interop and COM-related tests that are incompatible with interpreter execution.
- Adds
InterpreterActiveruntime test mode detection and skipping infrastructure - Applies skip attributes to tests that depend on marshalled calli, varargs, or COM interop features
- Updates XUnit package versions to support the new test skipping functionality
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/tests/Common/XUnitWrapperGenerator/RuntimeTestModes.cs |
Adds new InterpreterActive enum value for runtime test mode detection |
src/tests/Common/CoreCLRTestLibrary/CoreClrConfigurationDetection.cs |
Implements detection logic for interpreter mode using environment variables |
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs |
Adds condition generation for skipping tests when interpreter is active |
| Various test files | Applies SkipOnCoreClrAttribute with interpreter-specific skip reasons to incompatible tests |
eng/Version.Details.xml and eng/Version.Details.props |
Updates XUnit package versions to support new test skipping functionality |
src/tests/Common/CoreCLRTestLibrary/CoreClrConfigurationDetection.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
jkotas
reviewed
Sep 24, 2025
kg
changed the title
|
I have added some of the test failures from the Interop suite to #118618 |
kg
force-pushed
the
interp-interop-suite-2
branch
from
4410275 to
33df749
Compare
kg
force-pushed
the
interp-interop-suite-2
branch
from
33df749 to
ffef0f3
Compare
|
Down to 3 merged test failures and 0 independent test failures, by my local measure. Only noticed the merged ones now that the others are gone. |
kg
force-pushed
the
interp-interop-suite-2
branch
2 times, most recently
from
19ece5f to
c6ddef1
Compare
kg
removed
the
NO-MERGE
src/tests/Common/CoreCLRTestLibrary/CoreClrConfigurationDetection.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 1, 2025
jkotas
reviewed
Oct 1, 2025
jkotas
reviewed
Oct 1, 2025
jkotas
reviewed
Oct 1, 2025
src/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs
Outdated
Show resolved
Hide resolved
kg
added
the
NO-MERGE
|
Marking as no-merge until requested changes flow from arcade |
Add an interpreter-fixme comment in a test that's failing
kg
force-pushed
the
interp-interop-suite-2
branch
from
785d0fc to
f0ed28e
Compare
kg
removed
the
NO-MERGE
jkotas
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the Interop suite does not finish executing due to various crashes in the interpreter. This PR disables all the tests that are broken due to known interpreter limitations we have no plans to fix.
One test is still broken and has been added to the list in #118618 along with an Interpreter-FIXME comment at the broken place in the test.