[browser] build more subsets + runtime interp test #120359
Conversation
pavelsavara
added
arch-wasm
pavelsavara
changed the title
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
Co-authored-by: SingleAccretion <[email protected]>
pavelsavara
force-pushed
the
browser_src_tests
branch
from
1bfc7c8 to
90eb1c6
Compare
pavelsavara
force-pushed
the
browser_src_tests
branch
from
3c8b4fd to
af94529
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables building more subsets for the browser target and adds runtime interpreter tests for WebAssembly. The main goal is to expand CI capabilities for browser builds by switching from clr.runtime+libs to the full clr+libs subset and building JIT interpreter tests specifically for WASM.
Key changes:
- Switch browser builds to use the full
clr+libssubset in Release configuration - Enable native test building for browser targets by parameterizing library types
- Add conditional compilation for WASM interpreter tests with fallback behavior
Reviewed Changes
Copilot reviewed 122 out of 122 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/runtime.yml | Updates browser build to use clr+libs subset and adds interpreter test build step |
| src/tests/CMakeLists.txt | Adds WASM-specific configuration with static library type and compiler flags |
| src/tests/JIT/interpreter/Interpreter.cs | Adds WASM-specific early return and P/Invoke conditionals |
| Multiple CMakeLists.txt files | Replaces hardcoded SHARED with ${TEST_LIB_TYPE} variable |
| Various configuration files | Updates build configurations and dependency handling for browser/WASM targets |
|
|
||
| # add the executable | ||
| add_library (pinvoke SHARED ${SOURCES}) | ||
| add_library (pinvoke ${TEST_LIB_TYPE} ${SOURCES}) |
There was a problem hiding this comment.
The whole shared -> static lib change is "for the future" currently, since we don't have the code for linking into the (in-tree) host, right?
There was a problem hiding this comment.
right, we don't have generated pinvoke for coreCLR (but @radekdoulik has on his shortlist) and we are not considering on dynamic linking at all.
There was a problem hiding this comment.
I did consistent change for all those 120 files. But I need just 1 right now.
Co-authored-by: SingleAccretion <[email protected]>
| postBuildSteps: | ||
| - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests.yml | ||
| parameters: | ||
| testBuildArgs: test JIT/interpreter/Interpreter.csproj |
There was a problem hiding this comment.
<FeatureInterpreter> is currently conditional on ('$(Platform)' == 'x64' OR '$(Platform)' == 'arm64') AND ('$(Configuration)' == 'debug' OR '$(Configuration)' == 'checked') in clr.featuredefines.props. How will the interpreter tests pass in release configuration?
There was a problem hiding this comment.
goal of this PR is only to build it, not to make it run. It's indeed not working in Release yet.
There was a problem hiding this comment.
Maybe add a comment to that effect so anyone investigating knows, but sounds fine then
clr+libson CIReleasebecause that's whatsrc/testsneedjitinterface_wasm.dlldependencyclr.nativecorelibsubset from browsereng/liveBuilds.targetsmono specific, disable part temporarilyhost.nativesubset temporarilysrc/tests/JIT/interpreter/on CIset(TEST_LIB_TYPE STATIC)for WASM andset(TEST_LIB_TYPE SHARED)for otherssrc/mono/llvm/llvm-init.projfor windows debug