[browser] Expect fingerprint on assemblies promoted from build #120442
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewing
approved these changes
Oct 7, 2025
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the WebAssembly publish task to handle fingerprinted assembly assets correctly when the .NET SDK fingerprints static web assets. The changes ensure that assembly matching works properly when assemblies have fingerprinted names (e.g., System.Private.Corelib.FP.wasm instead of System.Private.Corelib.wasm).
Key changes:
- Adds logic to extract non-fingerprinted asset item specifications for proper assembly matching
- Updates assembly update logic to use original (non-fingerprinted) names when
FingerprintAssetsis enabled - Ensures satellite assemblies are handled consistently with the fingerprinting approach
ilonatommy
approved these changes
Oct 8, 2025
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs
Outdated
Show resolved
Hide resolved
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Oct 8, 2025
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18356980923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotnet/sdk#50949 we changed the identity of StaticWebAsset to contain fingerprint (
System.Private.Corelib.wasm->System.Private.Corelib.FP.wasm). If we do relink, these assemblies from build are replaced by assemblies from relink. If we don't, we need to accommodate for the fingerprint when matching assets from build.Contributes to #120393