Skip to content

Initial SslStream stress app work #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 6, 2019
Merged

Initial SslStream stress app work #290

merged 25 commits into from
Dec 6, 2019

Conversation

eiriktsarpalis
Copy link
Member

Adds the changes initially created for the corefx repo in dotnet/corefx#42560

Adds a console application for stress testing the SslStream class. The work somewhat imitates the setup that we already have in the http stress app: the app will open a fixed number of concurrent connections and run the stress scenaria for a fixed time period per connection (defaults at 2 minutes).

Unlike http2 there are no multiplexing concerns here, so the potential for stress tests seems less interesting. I've only included a single scenario for the moment: sending and echoing back of random data with basic integrity checks, using randomized permutations of Write, WriteAsync, WriteByte and Flush methods. I haven't been able to reproduce failures so far, though I haven't run the app for extensive periods of time yet.

@eiriktsarpalis eiriktsarpalis added area-System.Net.Security tenet-reliability Reliability/stability related issue (stress, load problems, etc.) labels Nov 26, 2019
@eiriktsarpalis eiriktsarpalis added this to the 5.0 milestone Nov 26, 2019
@eiriktsarpalis eiriktsarpalis mentioned this pull request Nov 26, 2019
Closed
@eiriktsarpalis
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@eiriktsarpalis
Copy link
Member Author

OMG why aren't pipelines sorted alphabetically 👀

image

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-windows

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

Pipelines working as expected, PR ready to go in.

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

I'm investigating a hanging behaviour that reproduces in the linux pipeline, which is why I haven't merged this yet.

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-windows

@eiriktsarpalis
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-ssl-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis eiriktsarpalis merged commit 2ef6db0 into dotnet:master Dec 6, 2019
@eiriktsarpalis eiriktsarpalis deleted the sslstress branch December 6, 2019 22:48
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub Awaiting requested review from stephentoub

@wfurt wfurt Awaiting requested review from wfurt

1 more reviewer

@davidsh davidsh davidsh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net.Security tenet-reliability Reliability/stability related issue (stress, load problems, etc.)

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eiriktsarpalis @davidsh