-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add configurations for SunOS CoreCLR managed build #36266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @ViktorHofer |
<PropertyGroup> | ||
<TargetsUnix>true</TargetsUnix> | ||
<TargetsSunOS>true</TargetsSunOS> | ||
<TestNugetRuntimeId>ubuntu.14.04-$(TargetArchitecture)</TestNugetRuntimeId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViktorHofer I have noticed that the TestNugetRuntimeId is set to ubuntu 14.04. Do we really use packages for that out-of -life version of Ubuntu or is this property actually never used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should update the
Lines 11 to 19 in 3b4c5a5
public static OSPlatform Browser { get; } = new OSPlatform("BROWSER"); | |
public static OSPlatform FreeBSD { get; } = new OSPlatform("FREEBSD"); | |
public static OSPlatform Linux { get; } = new OSPlatform("LINUX"); | |
public static OSPlatform OSX { get; } = new OSPlatform("OSX"); | |
public static OSPlatform Windows { get; } = new OSPlatform("WINDOWS"); |
Otherwise LGTM
I haven't touched |
Ok, makes sense, I wasn't sure about the extent of this change. |
Thanks for the NetBSD bits. |
IMAGE_FILE_MACHINE_NATIVE_OS_OVERRIDE
to 1992 for SunOS (initial release year of Solaris).maxProcesses
/NumProc
handling in shell scripts.Contributes to: #34944.