Skip to content

Conversation

am11
Copy link
Member

@am11 am11 commented May 12, 2020

  • Add msbuild configurations for coreclr managed build.
  • Add SunOS and NetBSD where it was missing.
  • Set IMAGE_FILE_MACHINE_NATIVE_OS_OVERRIDE to 1992 for SunOS (initial release year of Solaris).
  • Align maxProcesses/NumProc handling in shell scripts.
  • Fix some cmake configurations for cross compile (target vs. host).

Contributes to: #34944.

@ghost
Copy link

ghost commented May 12, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@am11
Copy link
Member Author

am11 commented May 12, 2020

cc @janvorli, @jkotas

<PropertyGroup>
<TargetsUnix>true</TargetsUnix>
<TargetsSunOS>true</TargetsSunOS>
<TestNugetRuntimeId>ubuntu.14.04-$(TargetArchitecture)</TestNugetRuntimeId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer I have noticed that the TestNugetRuntimeId is set to ubuntu 14.04. Do we really use packages for that out-of -life version of Ubuntu or is this property actually never used?

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should update the

public static OSPlatform Browser { get; } = new OSPlatform("BROWSER");
public static OSPlatform FreeBSD { get; } = new OSPlatform("FREEBSD");
public static OSPlatform Linux { get; } = new OSPlatform("LINUX");
public static OSPlatform OSX { get; } = new OSPlatform("OSX");
public static OSPlatform Windows { get; } = new OSPlatform("WINDOWS");

Otherwise LGTM

@am11
Copy link
Member Author

am11 commented May 12, 2020

I wonder if we should update the runtime/src/libraries/System.Runtime.InteropServices.RuntimeInformation/src/System/Runtime/InteropServices/RuntimeInformation/OSPlatform.cs

I haven't touched :/src/libraries and :/src/installer managed components as part of this PR, that is the next step.

@janvorli
Copy link
Member

I haven't touched :/src/libraries and :/src/installer managed components as part of this PR, that is the next step.

Ok, makes sense, I wasn't sure about the extent of this change.

@krytarowski
Copy link
Contributor

Thanks for the NetBSD bits.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants