Don't create a wrapper for run-v8.sh #44172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naricc
reviewed
Nov 3, 2020
naricc
approved these changes
Nov 3, 2020
jkoritzinsky
added
area-Infrastructure-mono
and removed
area-Infrastructure-coreclr
labels
|
Tagging subscribers to this area: @directhex |
|
Failures are unrelated. |
This was referenced Nov 5, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to run run-v8.sh directly when generating wrapper projects, we want to wrap the test script not the run-v8.sh script
It looks like we're generating a similar list in multiple places it might be possible unify the logic.