Skip to content

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Nov 8, 2020

Fix #44383.

Output (clretwallmain.h) before the change:

inline BOOL EventEnabledGCStart_V1() {return EventPipeEventEnabledGCStart_V1();}

inline BOOL EventEnabledGCStart_V2() {return EventPipeEventEnabledGCStart_V2();}

inline BOOL EventEnabledGCEnd() {return EventPipeEventEnabledGCEnd();}

Output (clretwallmain.h) after the change:

inline BOOL EventEnabledGCStart_V1() {return EventPipeEventEnabledGCStart_V1()|| EventXplatEnabledGCStart_V1();}

inline BOOL EventEnabledGCStart_V2() {return EventPipeEventEnabledGCStart_V2()|| EventXplatEnabledGCStart_V2();}

inline BOOL EventEnabledGCEnd() {return EventPipeEventEnabledGCEnd()|| EventXplatEnabledGCEnd();}

@sywhang sywhang merged commit 24cc3d6 into dotnet:master Nov 10, 2020
@sywhang sywhang deleted the dev/suwhang/44383 branch November 10, 2020 00:14
@sywhang
Copy link
Contributor Author

sywhang commented Nov 10, 2020

/backport to release/5.0

@github-actions
Copy link
Contributor

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/354947277

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

genEventing.py generates incorrect event enabled checks for Windows builds

3 participants