Skip to content

JIT: fix interaction of PGO and jitstress #47876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2021
Merged

JIT: fix interaction of PGO and jitstress #47876

merged 1 commit into from
Feb 5, 2021

Conversation

AndyAyersMS
Copy link
Member

We always need to run the profile data phase so that jit stress can inject
random profile counts if it so chooses.

Also, clean up a few dumping nits -- don't dump the profile query status until
we get around to trying to incorporate counts; summarize schema records before
asserting that we must have block counts, etc.

Closes #47839

@AndyAyersMS
JIT: fix interaction of PGO and jitstress
7034073 
We always need to run the profile data phase so that jit stress can inject
random profile counts if it so chooses.

Also, clean up a few dumping nits -- don't dump the profile query status until
we get around to trying to incorporate counts; summarize schema records before
asserting that we must have block counts, etc.

Closes dotnet#47839
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 4, 2021
@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

Will kick off CI stress runs shortly (pri0 jitstress1 passes locally)

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Feb 5, 2021 •
edited
Loading

Two OOMs in x86 jitstress test, seem unrelated (#10002 ?). Will ignore.

JIT.jit64\regress\vsw\373472\test_il\test_il

test2 exception: System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown.
   at StrideTest.Test2()
Test2 failed
test3 exception: System.OutOfMemoryException
...

@AndyAyersMS AndyAyersMS merged commit 5b41e82 into dotnet:master Feb 5, 2021
@AndyAyersMS AndyAyersMS deleted the FixPgoJitStressBadness branch February 5, 2021 01:53
@AndyAyersMS AndyAyersMS mentioned this pull request Feb 6, 2021
Closed
54 tasks
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Feb 24, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

2 participants

@AndyAyersMS @BruceForstall