SPMI: make method identity dependent on jit flags and isa flags #48082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible for SPMI tooling to retain multiple contexts for methods that only differ by flag settings. In particular, running SPMI with tiered compilation, SPMI can retain both the Tier0 and Tier1 contexts.
ghost
added
the
area-CodeGen-coreclr
|
cc @dotnet/jit-contrib We may want to add a bit more here -- for instance whether or not PGO data was available. |
BruceForstall
approved these changes
Feb 9, 2021
This was referenced Feb 12, 2021
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for SPMI tooling to retain multiple contexts for methods
that only differ by flag settings. In particular, running SPMI with tiered
compilation, SPMI can retain both the Tier0 and Tier1 contexts.