Skip to content

Superpmi collection pipeline improvements #49385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 10, 2021
Merged

Superpmi collection pipeline improvements #49385

merged 14 commits into from
Mar 10, 2021

Conversation

kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Mar 9, 2021 •
edited
Loading

  • Fail the job if merge-mch fails
  • Upload single merged .mch zipped file to azure artifacts. This will save lot of space on azure artifacts because earlier we used to upload .mch files as it is.
  • Upload superpmi.log files from all the partitions separately
  • Use --zap_disable for CoreRun.exe instead of dotnet.exe during benchmark collection.

@kunalspathak
Do not pass --use-zapdisable to dotnet
b8c01b4 
But instead pass to individual CoreRun.exe that is launched during benchmark run. That way we do not slow down the launch of dotnet.exe process.
@kunalspathak
Fail superpmi collection pipeline if there was no valid .mch files we…
5bc8515 
…re found to merge
@kunalspathak
Upload merged .mch files as zipped artifacts
987e66b 
TODO: Upload the superpmi.log from all the partition runs
@kunalspathak
TEMP: New Jit guid
e89ef69 
- Add new JIT guid so we don't overwrite the existing .mch files
- Disable all the runs except benchmarks
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 9, 2021
@kunalspathak kunalspathak changed the title Spmi Superpmi collection pipeline improvements Mar 9, 2021
@kunalspathak kunalspathak marked this pull request as ready for review March 9, 2021 23:25
@kunalspathak
Copy link
Contributor Author

@dotnet/jit-contrib , @BruceForstall

BruceForstall
BruceForstall approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements!

@kunalspathak
Copy link
Contributor Author

Glad that one of my prior job failed and we will not upload anything during failure cases.

@runfoapp runfoapp bot mentioned this pull request Mar 10, 2021
Closed
@kunalspathak kunalspathak merged commit 9d94811 into dotnet:main Mar 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2021
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kunalspathak @BruceForstall @JulieLeeMSFT