[mono][jit] read DebuggableAttribute(DebuggingModes) ctor; move to metadata/ #49505
+82
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
CoffeeFlux,
SamMonoRT,
thaystg and
vargaz
as code owners
ghost
added
the
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsPull Also support reading the This is needed to properly support #47274 (the
|
This comment has been minimized.
This comment has been minimized.
thaystg
reviewed
Mar 11, 2021
Pull is_jit_optimizer_disabled out of mini into metadata. Also support reading the DebuggingModes ctor
lambdageek
force-pushed
the
jit-disable-optimizations-from-enum
branch
from
72f660e to
0a8eed8
Compare
Co-authored-by: Thays Grazia <[email protected]>
|
@vargaz can you remember the details of 1d0195c (I can't see Xamarin bug 604486) It doesn't look like I'm wondering if enabling this in mono's JIT is a good idea now. Or if we should continue ignoring it as apparently it hasn't done any harm in the last 7-10 years. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull
is_jit_optimizer_disabledout of mini into metadata.Also support reading the
DebuggingModesctorThis is needed to properly support #47274 (the
DOTNET_MODIFIABLE_ASSEMBLIES=debugenv var for hot reload)