Skip to content

Increase test coverage for Exception.TargetSite #50275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Increase test coverage for Exception.TargetSite #50275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7521d08
Increase test coverage for Exception.TargetSite
MichalStrehovsky Mar 26, 2021
1767669
Apply suggestions from code review
MichalStrehovsky Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/libraries/System.Runtime/tests/System/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static void Exception_GetBaseException()
}

[Fact]
public static void Exception_TargetSite_Jit()
public static void Exception_TargetSite()
{
bool caught = false;

Expand All @@ -78,6 +78,32 @@ public static void Exception_TargetSite_Jit()

Assert.True(caught);
}

static void RethrowException()
{
try
{
ThrowException();
}
catch
{
throw;
}
}

[Fact]
public static void Exception_TargetSite_OtherMethod()
{
Exception ex = Assert.ThrowsAny<Exception>(() => ThrowException());
Assert.Equal(nameof(ThrowException), ex.TargetSite.Name);
}

[Fact]
public static void Exception_TargetSite_Rethrow()
{
Exception ex = Assert.ThrowsAny<Exception>(() => RethrowException());
Assert.Equal(nameof(ThrowException), ex.TargetSite.Name);
}

[Fact]
[ActiveIssue("https://github.com/mono/mono/issues/15140", TestRuntimes.Mono)]
Expand Down