Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 1, 2021

Backport of #50348 to release/5.0

Fixes #50283

/cc @wfurt

Customer Impact

This breaks Atlas MongoDB. As popular framework it has impact on wider user group.
While technically this is not regression in SocketHttpHandler as it never work before, option to use legacy handler was removed in 5.0 so there is no good solution.

The fix is small as our validation was too strict as RFC allows empty token but we failed to parse and reported as invalid.

Testing

Reported verified fix with daily 6.0 build. New test case was also added.

Risk

Small

@ghost ghost added the area-System.Net.Http label Apr 1, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #50348 to release/5.0

/cc @wfurt

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@wfurt wfurt added the Servicing-consider Issue for next servicing release review label Apr 1, 2021
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 6, 2021
@leecow leecow added this to the 5.0.6 milestone Apr 6, 2021
@danmoseley
Copy link
Member

@wfurt tactics asked to please ensure it's verified this fixes MongoDB (using 6.0 bits is OK). It says it was verified with 6.0 but not clear whether that's MongoDB.

@danmoseley danmoseley changed the title [release/5.0] ignore empty domain for digets auth [release/5.0] ignore empty domain for digest auth Apr 6, 2021
@wfurt
Copy link
Member

wfurt commented Apr 6, 2021

Yes, it was verified by the reporter to so I assume it was MongoDB. cc: @gao-artur to clarify.

@gao-artur
Copy link

Yes, verified it with Atlas MongoDB and it worked.

@danmoseley
Copy link
Member

Ok great then @Anipik can merge when green.

@Anipik
Copy link
Contributor

Anipik commented Apr 6, 2021

+ export __CrashDumpFolder=/home/helixbot/dotnetbuild/dumps
+ cat /root/helix/work/workitem/SetStressModes_normal.sh
#!/usr/bin/env bash
export COMPlus_DbgEnableMiniDump=1
export COMPlus_DbgMiniDumpName=$HELIX_DUMP_FOLDER/coredump.%d.dmp
+ export PATH=/root/helix/work/correlation/dotnet-cli:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ export DOTNET_ROOT=/root/helix/work/correlation/dotnet-cli
+ export DOTNET_CLI_TELEMETRY_OPTOUT=1
+ dotnet /root/helix/work/correlation/xunit.console.dll JIT/Generics/JIT.Generics.XUnitWrapper.dll -parallel collections -nocolor -noshadow -xml testResults.xml -trait TestGroup=JIT.Generics
Microsoft.DotNet.XUnitConsoleRunner v2.5.0 (64-bit .NET 5.0.0)
  Discovering: JIT.Generics.XUnitWrapper
  Discovered:  JIT.Generics.XUnitWrapper
  Starting:    JIT.Generics.XUnitWrapper
  Finished:    JIT.Generics.XUnitWrapper
=== TEST EXECUTION SUMMARY ===
   JIT.Generics.XUnitWrapper  Total: 41, Errors: 0, Failed: 0, Skipped: 0, Time: 4.830s
+ export _commandExitCode=0

the leg timed out after passing all the tests., hence going forward and merging this one.

@Anipik Anipik merged commit e1655ab into release/5.0 Apr 6, 2021
@jkotas jkotas deleted the backport/pr-50348-to-release/5.0 branch April 10, 2021 05:15
@ghost ghost locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net.Http Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants