-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix to build mono on Windows with ninja by default as well #50793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This got broken by dotnet@8c2158f since we no longer passed /p:Ninja=true down to mono.proj
Tagging subscribers to this area: @directhex |
Looks like this was missed in the initial PR because it didn't touch any files in src/mono so CI didn't trigger mono legs. @safern should we add |
Hmmm that should already be included: |
I do see mono build running on that PR build: Also this is the output for evaluate paths for the mono subset:
And here is the build for Browser on Windows that ran on that PR: |
@safern hmm you're right, it did run in the PR. I was confused because GitHub doesn't show it in the PR result summary at the end of the PR (only lists 100 statuses there) but does show it on the Checks tab: vs. This PR should still fix the issue though. |
|
This got broken by 8c2158f since we no longer passed
/p:Ninja=true
down to mono.proj from build.cmd/ps1Fixes #50753