[wasm][tests] Enable line numbers in stack traces #50893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsLibrary tests don't show line numbers, essentially because the .pdb With the patch:
|
kg
approved these changes
Apr 8, 2021
akoeplinger
reviewed
Apr 8, 2021
This was referenced Apr 8, 2021
Library tests don't show line numbers, essentially because the .pdb files never become available to the WasmAppBuilder . This is enabled by default for `Debug` builds only. To use it with `Release` builds, add `/p:DebuggerSupport=true` to the command line. With the patch: ``` fail: [FAIL] System.Reflection.Tests.MemberInfoTests.HasSameMetadataDefinitionAs__CornerCase_HasElementTypes info: Assert.All() Failure: 10 out of 10 items in the collection did not pass. info: [9]: Item: System.Double* info: Xunit.Sdk.AllException: Assert.All() Failure: 2 out of 10 items in the collection did not pass. info: [7]: Item: System.Double& info: Xunit.Sdk.TrueException: Assert.True() Failure info: Expected: True info: Actual: False info: at Xunit.Assert.True(Nullable`1 condition, String userMessage) in C:\Dev\xunit\xunit\src\xunit.assert\Asserts\BooleanAsserts.cs:line 95 info: at Xunit.Assert.True(Boolean condition) in C:\Dev\xunit\xunit\src\xunit.assert\Asserts\BooleanAsserts.cs:line 62 info: at System.Reflection.Tests.MemberInfoTests.<>c__DisplayClass31_1.<HasSameMetadataDefinitionAs__CornerCase_HasElementTypes>b__1(Type t2) in /Users/radical/dev/runtime/src/libraries/System.Reflection/tests/MemberInfoTests.cs:line 491 info: at Xunit.Assert.All[Type](IEnumerable`1 collection, Action`1 action) in C:\Dev\xunit\xunit\src\xunit.assert\Asserts\CollectionAsserts.cs:line 36 ```
radical
force-pushed
the
wasm-tests-debug-symbols
branch
from
0d38dc4 to
2245483
Compare
.. is enabled, which is for WasmDebugLevel != 0
|
Last few builds seem to be just stuck! |
akoeplinger
approved these changes
Apr 12, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library tests don't show line numbers, essentially because the .pdb
files never become available to the
WasmAppBuilder.This is enabled by default for
Debugbuilds only.To use it with
Releasebuilds, add/p:DebuggerSupport=trueto thecommand line.
With the patch: