Skip to content

Install crossgen, jitinterface, clrjit into the sharedframework folder in crosscomponent build. #51004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 commits merged into from
Apr 10, 2021

Conversation

jkoritzinsky
Copy link
Member

Fixes #50979

@ghost
Copy link

ghost commented Apr 9, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50979

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: 6.0.0

@jkoritzinsky jkoritzinsky changed the title Install crossgen, jitinterface, clrjit into the sharedframework folder. Install crossgen, jitinterface, clrjit into the sharedframework folder in crosscomponent build. Apr 9, 2021
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I don't see in this list is the cross bitness dac + dbi and the long name cross bit dac, which also used to exist in the arch/sharedFramework directory for windows. Can you please add these too?

@AntonLapounov
Copy link
Member

Thank you!

@ghost
Copy link

ghost commented Apr 9, 2021

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@sebastienros
Copy link
Member

sebastienros commented Apr 9, 2021

In case it's not a very straightforward fix (I see it's failing the build), can we revert the original PR in the meantime? It's now also blocking sdk releases from ingesting aspnet.

Update: The PR looks big, might be hard to revert it now.

@jkoritzinsky
Copy link
Member Author

@AntonLapounov can you look at the most recent commit? I don't think jitinterface_x86/64 needs to be in the folder since that's only used by crossgen2, which doesn't ship in the Runtime package (only crossgen1 does).

@AntonLapounov
Copy link
Member

That is correct. I mentioned the issue with the jitinterface library in #50979 (comment).

@ghost ghost merged commit 2a5bd56 into dotnet:main Apr 10, 2021
@jkoritzinsky jkoritzinsky deleted the crosscomponent_sharedframework branch April 12, 2021 16:50
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x64-hosted crossgen.exe missing in Microsoft.NETCore.App.Runtime.win-arm64 package
4 participants