-
Notifications
You must be signed in to change notification settings - Fork 5k
Install crossgen, jitinterface, clrjit into the sharedframework folder in crosscomponent build. #51004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsFixes #50979
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I don't see in this list is the cross bitness dac + dbi and the long name cross bit dac, which also used to exist in the arch/sharedFramework directory for windows. Can you please add these too?
Thank you! |
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
In case it's not a very straightforward fix (I see it's failing the build), can we revert the original PR in the meantime? It's now also blocking sdk releases from ingesting aspnet. Update: The PR looks big, might be hard to revert it now. |
…wasn't there in 6.0.0p3)
@AntonLapounov can you look at the most recent commit? I don't think jitinterface_x86/64 needs to be in the folder since that's only used by crossgen2, which doesn't ship in the Runtime package (only crossgen1 does). |
That is correct. I mentioned the issue with the jitinterface library in #50979 (comment). |
Fixes #50979