Skip to content

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 27, 2021

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20210429.1
  • Date Produced: 4/29/2021 8:51 PM
  • Commit: 307f6b0afd2fea639fffa97e67155bafe6aa8461
  • Branch: refs/heads/main

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21226.1 -> To Version 6.0.100-preview.5.21227.1
@ghost
Copy link

ghost commented Apr 27, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@marek-safar
Copy link
Contributor

@vitek-karas it looks like the linker SDK bump will need to be reverted and wait till P5 bump is propagated

@vitek-karas
Copy link
Member

This makes the roundtrip terribly long. We added a public API into runtime a week ago. We want to use it the linker. But we have to wait for the runtime to update its SDK build - which is done like once every 3 months...
In this case it's even worse - in order to correctly support the new API we need the linker changes in place... so we'll have runtime in this weird semi-broken state for multiple months...

@marek-safar
Copy link
Contributor

I agree with you but that's, unfortunately, the setup infra team has been pushing hard for the slow updates. There is a scheduled monthly update #51716 but right now it's way behind on what is needed here.

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21226.1 -> To Version 6.0.100-preview.5.21228.1
dotnet-maestro bot and others added 6 commits April 29, 2021 08:32
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21226.1 -> To Version 6.0.100-preview.5.21228.2
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21226.1 -> To Version 6.0.100-preview.5.21229.1
…ub.com:dotnet/runtime into darc-main-478bc32b-981e-494f-b9a1-e9824a6d702a
…corelib.

Basically a port of #51562 including changes as per PR feedback.
@marek-safar marek-safar merged commit ab644f4 into main May 3, 2021
@marek-safar marek-safar deleted the darc-main-478bc32b-981e-494f-b9a1-e9824a6d702a branch May 3, 2021 17:26
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants