Fixing the GetInterfaceMap tests for mono in the runtime repo. #52566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing 4 issues for GetInterfaceMap and default interface methods - Only methods marked as virtual on on interface should be added to the interface map. (no static or instance) - If the found target method is ambiguous (a diamond) the target is null. - If the found target method's class in an interface, then the target class is the interface class, else it is the class of the RuntimeType (aka this) - If the found target method is abstract (reabstraction) then the target is null. Fixes dotnet#34389
bholmes
requested review from
CoffeeFlux,
lambdageek,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsAddressing 4 issues for GetInterfaceMap and default interface methods
Fixes #34389
|
|
I would also like to see this in the mono/mono repo as well. AFAICT the only difference is some calls require the domain argument. |
|
@lambdageek please review |
lambdageek
approved these changes
Jun 2, 2021
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hello @lambdageek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
/azp run sync-runtime-to-mono |
This was referenced Jun 7, 2021
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing 4 issues for GetInterfaceMap and default interface methods
interface map. (no static or instance)
null.
class is the interface class, else it is the class of the RuntimeType
(aka this)
target is null.
Fixes #34389