-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Revert "Move ServiceCollection to abstractions (#52284)" #52576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit ad7455c. People are doing reflection...
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsThis reverts commit ad7455c. People are doing reflection...
|
I’m not sure I follow. If people use reflection, won’t the TypeForwardedTo still work? Can you give an example the reflection we want to keep working? |
Won’t this break #52363? |
Yep. I'm gonna bundle it with that change after this is merged. |
I don't get it. Why not just leave the original change in and close this PR? Why revert the change and put it back? |
Because it's blocking dependency flow to efcore dotnet/efcore#24861 😢 |
@davidfowl, is nothing else depending on the type move? In other words, would it have been fine to combine #52363 and ad7455c from the start? If so, I'm fine with reverting so that we can unblock dependency flow. |
To connect the dots for others. OData is using public reflection to locate |
I also made this PR to Odata |
@davidfowl are you planning to merge this or were you going to work around it in efcore? |
I'm debating. I feel like I want to work around it since the fix is approved in Odata. I'd like to get them to merge and push something. |
We're going to work around this in EF and fix Odata. |
This reverts commit ad7455c.
People are doing reflection...