Skip to content

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented May 24, 2021

It adds reference to Console in debug build to make it easier to add Console.WriteLine during debugging without need to modify project files. Two projects already had that but only for Unix. This change makes it consistent in common networking projects.

@wfurt wfurt requested a review from a team May 24, 2021 15:57
@ghost ghost added the area-System.Net label May 24, 2021
@ghost
Copy link

ghost commented May 24, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

It adds reference to Console in debug build to make it easier to add Console.WriteLine during debugging without need to modify project files. Two projects already had that but only for Unix. This change makes it consistent in common networking projects.

Author: wfurt
Assignees: -
Labels:

area-System.Net

Milestone: -

@geoffkizer
Copy link
Contributor

Nice change. I've also just done p/invoke to printf for this, but this seems better.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

BTW, do we already have the references in test projects?

@wfurt
Copy link
Member Author

wfurt commented May 25, 2021

It seems like test projects do not reference individual assemblies. When I test it, it just worked without any change @ManickaP.

@wfurt wfurt merged commit 3072d7f into dotnet:main May 25, 2021
@wfurt wfurt deleted the consoleDebug branch May 25, 2021 09:16
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants