Skip to content

Follow up on HostFactoryResolver changes #54052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

davidfowl
Copy link
Member

  • Cleaned up the comments to explain what ResolveHostFactory does.
  • Added entry point completed callback to let callers know when the entry point code is done running.
  • Added tests for the various callbacks.

Follow up from #53757 and dotnet/aspnetcore#33462

- Cleaned up the comments to explain what ResolveHostFactory does.
- Added entry point completed callback to let callers know when the entry point code is done running.
- Added tests for the various callbacks.
@ghost
Copy link

ghost commented Jun 11, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Cleaned up the comments to explain what ResolveHostFactory does.
  • Added entry point completed callback to let callers know when the entry point code is done running.
  • Added tests for the various callbacks.

Follow up from #53757 and dotnet/aspnetcore#33462

Author: davidfowl
Assignees: -
Labels:

area-Extensions-Hosting

Milestone: -

@davidfowl davidfowl merged commit b88b34c into main Jun 11, 2021
@jkotas jkotas deleted the davidfowl/hostresolver-followups branch June 13, 2021 16:27
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants