Skip to content

Print spill cost for RefPosition #54933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jun 30, 2021
Merged

Print spill cost for RefPosition #54933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/coreclr/jit/lsra.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2467,7 +2467,7 @@ void LinearScan::dumpVarRefPositions(const char* title)
printf(" (Interval %d)\n", interval->intervalIndex);
for (RefPosition* ref = interval->firstRefPosition; ref != nullptr; ref = ref->nextRefPosition)
{
ref->dump();
ref->dump(this);
}
}
else
Expand Down Expand Up @@ -4346,7 +4346,7 @@ void LinearScan::dumpRefPositions(const char* str)
printf("------------\n");
for (RefPosition& refPos : refPositions)
{
refPos.dump();
refPos.dump(this);
}
}
#endif // DEBUG
Expand Down Expand Up @@ -8895,7 +8895,7 @@ const char* LinearScan::getScoreName(RegisterScore score)
}
}

void RefPosition::dump()
void RefPosition::dump(LinearScan* linearScan)
{
printf("<RefPosition #%-3u @%-3u", rpNum, nodeLocation);

Expand Down Expand Up @@ -8969,6 +8969,8 @@ void RefPosition::dump()
{
printf(" regOptional");
}

printf(" wt=%.2f", linearScan->getWeight(this));
printf(">\n");
}

Expand Down
3 changes: 2 additions & 1 deletion src/coreclr/jit/lsra.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
/*****************************************************************************/
Expand Down Expand Up @@ -2444,7 +2445,7 @@ class RefPosition
return *this;
}

void dump();
void dump(LinearScan* linearScan);
#endif // DEBUG
};

Expand Down
6 changes: 3 additions & 3 deletions src/coreclr/jit/lsrabuild.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ RefPosition* LinearScan::newRefPosition(
(regRecord->lastRefPosition->refType != theRefType));
associateRefPosWithInterval(newRP);

DBEXEC(VERBOSE, newRP->dump());
DBEXEC(VERBOSE, newRP->dump(this));
return newRP;
}

Expand Down Expand Up @@ -620,7 +620,7 @@ RefPosition* LinearScan::newRefPosition(Interval* theInterval,

associateRefPosWithInterval(newRP);

DBEXEC(VERBOSE, newRP->dump());
DBEXEC(VERBOSE, newRP->dump(this));
return newRP;
}

Expand Down Expand Up @@ -2624,7 +2624,7 @@ void LinearScan::validateIntervals()
printf("-----------------\n");
for (RefPosition* ref = interval->firstRefPosition; ref != nullptr; ref = ref->nextRefPosition)
{
ref->dump();
ref->dump(this);
RefType refType = ref->refType;
if (!defined && RefTypeIsUse(refType))
{
Expand Down