Skip to content

Use EnumerateLines in TryParseStatusFile #55266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

Use EnumerateLines in TryParseStatusFile #55266

merged 1 commit into from
Jul 8, 2021

Conversation

stephentoub
Copy link
Member

@ghost
Copy link

ghost commented Jul 7, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

GrabYourPitchforks
GrabYourPitchforks approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a slight behavioral change since it will now split on more chars than just \n, but judging from the use case I think that's ok?

@stephentoub
Copy link
Member Author

I think so. There shouldn't be any \rs in the input.

@stephentoub stephentoub merged commit 45b384d into dotnet:main Jul 8, 2021
@stephentoub stephentoub deleted the enumeratelines branch July 8, 2021 16:46
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz mentioned this pull request Jul 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephentoub @GrabYourPitchforks