Skip to content

Disable some System.Drawing.Common tests failing on Windows Mono #55656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Disable some System.Drawing.Common tests failing on Windows Mono #55656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/System.Drawing.Common/tests/IconTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,7 @@ public void ToBitmap_BitmapIconFromHandle_ReturnsExpected()
private const string DontSupportPngFramesInIcons = "Switch.System.Drawing.DontSupportPngFramesInIcons";

[ActiveIssue("https://github.com/dotnet/runtime/issues/22221", TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55655", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ConditionalFact(Helpers.IsDrawingSupported)]
public void ToBitmap_PngIconSupportedInSwitches_Success()
{
Expand Down Expand Up @@ -647,6 +648,7 @@ void VerifyPng()
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/22221", TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55655", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ConditionalFact(Helpers.IsDrawingSupported)]
public void ToBitmap_PngIconNotSupportedInSwitches_ThrowsArgumentOutOfRangeException()
{
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Drawing.Common/tests/Imaging/MetafileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,7 @@ public void Ctor_RectangleEmptyI_Success(string description)
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/55655", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ConditionalFact(Helpers.IsDrawingSupported)]
public void Ctor_IntPtrZeroIV_ThrowsArgumentException()
{
Expand All @@ -866,6 +867,7 @@ public void Ctor_IntPtrZeroIV_ThrowsArgumentException()
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/55655", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ConditionalTheory(Helpers.IsDrawingSupported)]
[MemberData(nameof(MetafileFrameUnit_Invalid_TestData))]
public void Ctor_InvalidFrameUnitIII_ThrowsArgumentException(MetafileFrameUnit frameUnit)
Expand All @@ -883,6 +885,7 @@ public void Ctor_InvalidFrameUnitIII_ThrowsArgumentException(MetafileFrameUnit f
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/55655", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ConditionalTheory(Helpers.IsDrawingSupported)]
[MemberData(nameof(EmfType_Invalid_TestData))]
public void Ctor_InvalidEmfTypeIII_ThrowsArgumentException(EmfType emfType)
Expand Down