Skip to content

Conversation

adamsitnik
Copy link
Member

fixes #45592

@adamsitnik adamsitnik added area-Extensions-Caching needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Aug 18, 2021
@adamsitnik adamsitnik added this to the 7.0.0 milestone Aug 18, 2021
@ghost
Copy link

ghost commented Aug 18, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 18, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan, @michaelgsharp
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #45592

Author: adamsitnik
Assignees: -
Labels:

area-Extensions-Caching, needs-breaking-change-doc-created

Milestone: 7.0.0

@eerhardt
Copy link
Member

    public async Task OnceExpiredIsSetToTrueItRemainsTrue()

Any reason why this test wasn't turned into a Theory?


Refers to: src/libraries/Microsoft.Extensions.Caching.Memory/tests/CacheEntryScopeExpirationTests.cs:513 in 4684c51. [](commit_id = 4684c51, deletion_comment = False)

@adamsitnik
Copy link
Member Author

adamsitnik commented Aug 20, 2021

Any reason why this test wasn't turned into a Theory?

There is just one entry being created in this test (no dependencies to other linked entries) and it just verifies whether setting entry as expired is thread-safe (not related to tracking)

@adamsitnik adamsitnik requested a review from eerhardt August 20, 2021 04:22
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eerhardt
Copy link
Member

Failures are unrelated. Timing out due to dotnet/core-eng#14346

@eerhardt eerhardt merged commit f2ce707 into dotnet:main Sep 14, 2021
@EgorBo
Copy link
Member

EgorBo commented Sep 23, 2021

arm64 improvements: dotnet/perf-autofiling-issues#1537

@adamsitnik adamsitnik deleted the issue45592 branch October 15, 2021 14:27
@adamsitnik
Copy link
Member Author

To be honest I've not merged it because I wanted to check if something in ASP.NET repo is going to get broken with this change. It has been a month since it was merged and nobody started screaming. I guess it just proves that it was good idea to introduce the breaking change and disable the tracking by default.

@sebastienros
Copy link
Member

@adamsitnik someone finally screamed

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
@ericstj
Copy link
Member

ericstj commented Oct 4, 2022

@adamsitnik were you planning to create a breaking change document for this?

@ericstj ericstj assigned adamsitnik and unassigned eerhardt Oct 4, 2022
@maryamariyan
Copy link
Contributor

I just added dotnet/docs#31739

@maryamariyan maryamariyan removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 12, 2022
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Oct 12, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 12, 2022
@ericstj ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 12, 2022
@adamsitnik
Copy link
Member Author

I just added dotnet/docs#31739

@maryamariyan big thanks for doing that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Caching breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MemoryCache] Add possibility to disable linked cache entries
7 participants