Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 24, 2021

Backport of #57946 to release/6.0

Fixes #57907

Intentionally left out ***CancellableTask and ***SyncForceNonBlocking to somewhat counterpart the increased execution time. I don't think we need all the cases for this particular test.

/cc @karelz @antonfirsov

Customer Impact

High impact on CI -- 1 failure per day on official runs, mostly release/6.0* branches.

Testing

CI run + monitoring test results in Kusto.

Risk

Low, test-only change

@ghost
Copy link

ghost commented Aug 24, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57946 to release/6.0

/cc @karelz @antonfirsov

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@karelz karelz added this to the 6.0.0 milestone Aug 24, 2021
@karelz karelz requested a review from danmoseley August 24, 2021 07:51
@antonfirsov
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member

We were too eager merging #57946, forgot to make the test base class abstract and did not run outerloop. Tests should be failing on the current main without that. Opened #58003 against main, and pushed ed4bbef to this PR.

@karelz
Copy link
Member

karelz commented Aug 24, 2021

The test failure is known external server hiccup - #58018:

System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate(uri: "http://httpbin.org/deflate", expectedContent: "\"deflated\": true") [FAIL]
      System.Net.Http.HttpRequestException : Response status code does not indicate success: 502 (Bad Gateway).

Re-running to get clean CI

@danmoseley
Copy link
Member

Test only change - approved

@danmoseley danmoseley merged commit d6065b6 into release/6.0 Aug 24, 2021
@danmoseley danmoseley deleted the backport/pr-57946-to-release/6.0 branch August 24, 2021 17:07
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants