Skip to content

Conversation

uweigand
Copy link
Contributor

@uweigand uweigand requested a review from marek-safar as a code owner August 24, 2021 13:29
@ghost ghost added area-CoreLib-mono community-contribution Indicates that the PR has been added by a community member labels Aug 24, 2021
@jkotas
Copy link
Member

jkotas commented Aug 24, 2021

Do we need to add test?

@SamMonoRT
Copy link
Member

@uweigand - can we get a test added for the change ?

* Fixes #58019

* Also allow null Array value, and re-enable test case.
@uweigand
Copy link
Contributor Author

@uweigand - can we get a test added for the change ?

Turns out there was already a test case, but disabled on Mono. Re-enabling the test case showed the failure fixed by this PR originally, and it also fails because of another reason: the Mono implementation rejected a null field value of Array type, which CoreCLR accepts and the test case uses. I've added a fix for this second issue as well, and re-enabled the test case.

@ghost
Copy link

ghost commented Aug 27, 2021

Hello @marek-safar!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1630a67 into dotnet:main Aug 27, 2021
@uweigand uweigand deleted the mono-customattrbuilder branch August 27, 2021 18:21
@srxqds
Copy link
Contributor

srxqds commented Aug 28, 2021

@marek-safar could this backport to release/6.0?

@lambdageek
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1177581011

@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mono] CustomAttrBuilder does not support RuntimeType arguments

6 participants