[release/6.0-rc1] X86 Debug Stack offsets are encoded divided by 4 #58094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
ghost
added
the
|
runtime (CoreCLR Pri0 Runtime Tests Run windows x86 checked) hit #11063 |
jeffschwMSFT
approved these changes
Aug 25, 2021
jeffschwMSFT
added
the
Servicing-consider
AndyAyersMS
approved these changes
Aug 25, 2021
jeffschwMSFT
added
Servicing-approved
|
@Anipik can you help with merging this change when appropriate? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58070 to release/6.0-rc1
/cc @davidwrighton
Customer Impact
Locals in ready to run compiled binaries targeting X86 will not be handled correctly on an X86 debugger. This was discovered by the VS debugger team, and @gregg-miskelly filed #57951. The impact noticed by the VS debugger team was that debugging Wait relationships between Tasks could not be understood on a Windows X86 build of the runtime.
Testing
Manual inspection of generated local information in R2R images was verified to be correct.
Risk
Low, Debugging information for locals in X86 R2R images may continue to be incorrect.
Regression
Yes. This is a bug that was not present in Crossgen 1.