Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 26, 2021

Backport of #58143 to release/6.0-rc1

/cc @AntonLapounov

Customer Impact

It is quite difficult to debug the official Crossgen2 package, because symbol files (*.pdb, *.dbg, *.dwarf) for JIT libraries and all ILCompiler assemblies are not be preserved or indexed anywhere.

Testing

Verified that with this changes the symbols package contains the required symbol files.

Risk

Low — just adding additional symbol files to the symbols package.

@ghost
Copy link

ghost commented Aug 26, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a code review and we can take for consideration for RC1.

@AntonLapounov AntonLapounov added the Servicing-consider Issue for next servicing release review label Aug 27, 2021
@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Aug 27, 2021
@jeffschwMSFT
Copy link
Member

@Anipik this will be ready to merge to soon.

@Anipik Anipik merged commit 16e9d33 into release/6.0-rc1 Aug 27, 2021
@AntonLapounov AntonLapounov deleted the backport/pr-58143-to-release/6.0-rc1 branch August 28, 2021 01:16
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2021
@teo-tsirpanis teo-tsirpanis removed the Servicing-consider Issue for next servicing release review label Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-crossgen2-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants