[release/6.0] [mini] Dynamically allocate a buffer for large runtime invoke results #58364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
If the return type is a struct that's bigger than our buffer, malloc a buffer for it instead of using a fixed-size stack buffer
Fixes various tests in InvokeRefReturnNetcoreTests
github-actions
bot
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
marek-safar
approved these changes
Aug 31, 2021
This was referenced Sep 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58215 to release/6.0
/cc @lambdageek
Customer Impact
System.Text.Jsonto serialize large structs will crash.ref-return method will crash instead of throwing aNullReferenceException.Testing
CI and manual testing
Risk
Low. For (1) all the logic in the runtime is the same, we just dynamically allocate a big enough buffer. For (2) we already do the right thing when using LLVM AOT - this is just fixing up the non-LLVM AOT case.