Fix crossgen2 calli GC hole by unifying MethodDesc/MethodSignature IsMarshallingRequired logic #58430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unmanaged calli crossgen2 was not properly checking all necessary conditions for a pinvoke being required. In particular it did not check for managed byrefs. Unify the MethodDesc/MethodSignature logic to get all the checks. Fix dotnet#58259
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFor unmanaged calli crossgen2 was not properly checking all necessary Fix #58259 cc @dotnet/crossgen-contrib
|
jakobbotsch
added
area-crossgen2-coreclr
and removed
area-CodeGen-coreclr
jakobbotsch
changed the title
|
This one should probably be backported to 6.0. |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test failure looks like #58481 |
|
@davidwrighton and @MichalStrehovsky Please review the code. |
jkotas
approved these changes
Sep 2, 2021
MichalStrehovsky
approved these changes
Sep 3, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1197309432 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unmanaged calli crossgen2 was not properly checking all necessary
conditions for a pinvoke being required. In particular it did not check
for managed byrefs. Unify the MethodDesc/MethodSignature logic to get
all the checks.
Fix #58259
cc @dotnet/crossgen-contrib