[release/6.0] run System.IO.Tests .NET 5 compat tests on every OS #58613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsBackport of #58611 to release/6.0 /cc @adamsitnik Customer ImpactTestingRisk
|
akoeplinger
approved these changes
Sep 3, 2021
|
cc @danmoseley tell mode for infra or test related changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58611 to release/6.0
/cc @adamsitnik
Customer Impact
In .NET 6, we have re-written FileStream. Initially, we have done that only for Windows, hence
Net5Compat.Testsprojects were targetting only$(NetCoreAppCurrent)-windows. When we have added new Unix implementation in #55191, we forgot to enable these tests for Unix.This PR enables
System.IOtests to test the old, .NET 5 Compat mode on Unix.Testing
The tests are passing.
Risk
None, it's not a product change. It's actually lowering riks of introducing a bug to the .NET 5 Compat mode
FileStreamimplementation