[release/6.0] Increase some of the DnsEndPointTest timeouts #58617
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #58129 to release/6.0 /cc @karelz @antonfirsov Customer ImpactTestingRisk
|
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Unrelated runtime-staging failures, rerunning them. |
|
@danmoseley this is ready for your approval - test only change. |
| public const int PassingTestTimeout = 10_000; | ||
| public const int PassingTestLongTimeout = 30_000; |
There was a problem hiding this comment.
Why not just have PassingTestTimeout be 30s rather than having two different timeouts? The purpose of the "passing" timeout is we expect these to always pass in well under this timeout, and if it times out, the test is going to fail. Taking an extra 20 seconds in the case of a failing test shouldn't be a problem, since tests shouldn't be failing.
There was a problem hiding this comment.
It was introduced based on CR feedback in the PR on main: #58129 (comment)
@stephentoub I assume your comment is non-blocking for 6.0 merging. We can reopen the discussion in main once @antonfirsov is back.
|
Approved - test only stability change. The tweak mentioned can happen in main. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #58129 to release/6.0
Long story short:
I have spent several hours trying to get a test run on SLES in order to repro #57929, no success so far, and it may take days to make progress, since I'm unfamiliar with SLES.
I recommend to bump the timeout values for now, and see if it helps with the issue. If not, we may invest into another round of investigation.
(hopefully) fixes #57929
/cc @karelz @antonfirsov
Customer Impact
Massive failures (6 per day) in CI mostly on SLES and only in release/6.0* branches.
Testing
Outerloop test run
Risk
Low: Test-only change - changing only timeouts.