Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 3, 2021

Backport of #58553 to release/6.0

/cc @akoeplinger @uweigand

Customer Impact

Using source-build to build the dotnet/runtime repo was failing on s390x where the primary runtime is Mono instead of CoreCLR. This fixes the source-build build so it works on that platform.

Testing

Manual testing.

Risk

Low, this only impacts source-build on s390x.

* Do not disable Mono in source-build if it is the primary runtime
@ghost
Copy link

ghost commented Sep 3, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger akoeplinger added this to the 6.0.0 milestone Sep 3, 2021
@akoeplinger akoeplinger added the source-build Issues relating to dotnet/source-build label Sep 3, 2021
@akoeplinger akoeplinger merged commit 693e2f3 into release/6.0 Sep 3, 2021
@akoeplinger akoeplinger deleted the backport/pr-58553-to-release/6.0 branch September 3, 2021 14:59
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Build-mono source-build Issues relating to dotnet/source-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants