Retarget DOTNETHOME when installing x64 on ARM64 #58669
Conversation
ericstj
added
the
NO-MERGE
ericstj
requested review from
jkoritzinsky,
wli3,
joeloff,
sfoslund and
hoyosjs
|
Could it be renamed to something like |
This is not a new identifier. This a pre-existing directory identifier and public property exposed by the MSI installers. Changing it is breaking. All these changes do is detect when x64 is being installed on ARM64, and the user hasn't specified DOTNETHOME, redirect to an x64 subfolder. See dotnet/arcade#7785 |
ericstj
removed
the
NO-MERGE
|
Ok reviewers, this should be ready to review now. #58681 brought the arcade changes over that enable this. I'd like to get this in ASAP so we have 7.0 builds to smoke test on ARM64, then we can request the port for this to 6.0. Thanks! |
* Retarget DOTNETHOME when installing x64 on ARM64 (#58669) * Only set path in x64 mac installer when installing on x64 (#59210) * Only set path in x64 mac installer when installing on x64 In other words don't set the path for x64 installer on ARM64 * Remove postinstall script from hostfxr There should be no need for both the host and hostfxr to set the path to dotnet. Since the host installs dotnet, it should be the only package responsible for this. * Make postinstall set install_location on mac Also refactor script to use a template so that we don't need to fork the script. * fix some syntax errors in script * Update src/installer/pkg/sfx/installers/dotnet-host.proj Co-authored-by: Adeel Mujahid <[email protected]> * Refine uname regular expressions Co-authored-by: Adeel Mujahid <[email protected]> * Updating dependencies from https://github.com/dotnet/arcade build 20210917.3 Co-authored-by: Adeel Mujahid <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Replaces #58059