[wasm][debugger] Fix pause on exception behavior #58728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radical
reviewed
Sep 8, 2021
Comment on lines
+1394
to
+1395
| //we only need this check if it's a non-vs debugging | ||
| if (sessionId == SessionId.Null) |
There was a problem hiding this comment.
How is this checking for non-vs debugging?
And does SessionId.Null represent a default context, which might have an entry in contexts dictionary?
There was a problem hiding this comment.
As I could see by debugging, when I'm debugging from VS SessionId is not null, when I'm debugging from chrome SessionId is null.
Maybe @lewing knows how to explain better.
There was a problem hiding this comment.
I think, the non-null sessionId means that it is a "flat access".
IIUC, chrome devtools will move to it too, so this might not be a good test. I'll defer to @lewing .
Co-authored-by: Ankit Jain <[email protected]>
radical
reviewed
Sep 8, 2021
lewing
approved these changes
Sep 9, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1218488704 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial status of Pause On Exception is correctly sent to BrowserDebugProxy when the debugging is started from VS. So we don't need the hacky to discover the initial status. And we will not print the message described in the issue below anymore.
When we debugging from chrome this is still useful, but I couldn't hide the message printed on console.
Added more tests when throwing an Exception and not a CustomException as we were testing in the unit test before.
Fixes #58509 (comment)
@lewing I would like to backport to preview 2, do you think that makes sense?